Skip to content

fix rmtree failure in coreml #14632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
facebook-github-bot merged 1 commit into from
Sep 26, 2025
Merged

fix rmtree failure in coreml #14632

facebook-github-bot merged 1 commit into from
Sep 26, 2025

Conversation

@YIWENX14
Copy link
Contributor

@YIWENX14 YIWENX14 commented Sep 26, 2025

Summary: Use actual temp directory instead of local folder "tmp/" to avoid rmtree failure.

Differential Revision: D83371990

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14632

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit d38171f with merge base 684b5fd (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 26, 2025

@YIWENX14 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83371990.

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@limintang limintang self-requested a review September 26, 2025 20:11
@YIWENX14 @facebook-github-bot
fix rmtree failure in coreml export (pytorch#14632)
d38171f 
Summary:

Use actual temp directory  instead of local folder "tmp/" to avoid rmtree failure.

Reviewed By: limintang, metascroy

Differential Revision: D83371990
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Sep 26, 2025

@YIWENX14 has exported this pull request. If you are a Meta employee, you can view the originating diff in D83371990.

@facebook-github-bot facebook-github-bot merged commit 8e6e320 into pytorch:main Sep 26, 2025
135 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@limintang limintang limintang approved these changes

@shoumikhin shoumikhin Awaiting requested review from shoumikhin shoumikhin is a code owner

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YIWENX14 @facebook-github-bot @limintang